Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PreserveReference is using the src PropertyName to set the Destination property. #681

Open
OFark opened this issue Feb 23, 2024 · 0 comments

Comments

@OFark
Copy link

OFark commented Feb 23, 2024

public sealed record FirstType()
{
	public bool ChargeToAccount {get; init;}
	public string Name {get; set;}
}

public sealed record SecondType()
{
	public bool CanChargeToAccount { get; init; }
	public string Name { get; set; }
}

If I run:

TypeAdapterConfig.GlobalSettings.ForType<FirstType, SecondType>()
		   .PreserveReference(true).Map(st => st.CanChargeToAccount, ft => ft.ChargeToAccount);
	
	var ft = new FirstType() { ChargeToAccount = true, Name = "Jeff"};
	
	var st = ft.Adapt<SecondType>();	

The generated script is:

public UserQuery.SecondType Main(UserQuery.FirstType p1)
{
    if (p1 == null)
    {
        return null;
    }
    MapContextScope scope = new MapContextScope();
   
    try
    {
        object cache;
       
        Dictionary<ReferenceTuple, object> references = scope.Context.References;
        ReferenceTuple key = new ReferenceTuple(p1, typeof(UserQuery.SecondType));
       
        if (references.TryGetValue(key, out cache))
        {
            return (UserQuery.SecondType)cache;
        }
        UserQuery.SecondType result = new UserQuery.SecondType();
        references[key] = (object)result;
       
        typeof(UserQuery.SecondType).GetProperty("ChargeToAccount").SetValue(result, (object)p1.ChargeToAccount);
        result.Name = p1.Name;
        return result;
    }
    finally
    {
        scope.Dispose();
    }
   
}

note this line: typeof(UserQuery.SecondType).GetProperty("ChargeToAccount").SetValue(result, (object)p1.ChargeToAccount);

should be typeof(UserQuery.SecondType).GetProperty("CanChargeToAccount").SetValue(result, (object)p1.ChargeToAccount);

CanChargeToAccount is coming through as ChargeToAccount which isn't a valid property for SecondType.

FYI Mapster 7.3.0 produces the right script:

public UserQuery.SecondType Main(UserQuery.FirstType p1)
{
    if (p1 == null)
    {
        return null;
    }
    MapContextScope scope = new MapContextScope();
   
    try
    {
        object cache;
       
        Dictionary<ReferenceTuple, object> references = scope.Context.References;
        ReferenceTuple key = new ReferenceTuple(p1, typeof(UserQuery.SecondType));
       
        if (references.TryGetValue(key, out cache))
        {
            return (UserQuery.SecondType)cache;
        }
        UserQuery.SecondType result = new UserQuery.SecondType();
        references[key] = (object)result;
       
        result.CanChargeToAccount = p1.ChargeToAccount;
        result.Name = p1.Name;
        return result;
    }
    finally
    {
        scope.Dispose();
    }
   
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant