Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass an IRenderer to the constructor of the RasterizingLayer #18

Closed
pauldendulk opened this issue Oct 15, 2014 · 5 comments
Closed

Pass an IRenderer to the constructor of the RasterizingLayer #18

pauldendulk opened this issue Oct 15, 2014 · 5 comments

Comments

@pauldendulk
Copy link
Member

So the user can override the default rasterizer.

@pauldendulk
Copy link
Member Author

Done in commit: pauldendulk@1362ee2

@pauldendulk
Copy link
Member Author

It is now also possible to use different renderers for different layers. For instance ShapefileSample.CreateLayer could be like this:

       var gdi = new GdiMapRenderer();
       layers.Add(new RasterizingLayer(CreateCountryLayer(countrySource), rasterizer: gdi));
       layers.Add(new RasterizingLayer(CreateCityLayer(citySource)));
       layers.Add(new RasterizingLayer(CreateCountryLabelLayer(countrySource)));
       layers.Add(new RasterizingLayer(CreateCityLabelLayer(citySource), rasterizer: gdi));

@smremde
Copy link
Contributor

smremde commented Oct 27, 2014

When this commit is published to nuget, individual renders should be published as individual packages.

@pauldendulk
Copy link
Member Author

Why? For practical reasons it would not make a difference since you can specify which assemblies are suited for a specific platform.

I would like to keep the functionality the same for all platforms and with Gdi included there will at least be a difference in the number of renderers. That would be an argument to split them. But having many nuget packages also makes it harder to maintain. Not sure if I would be willing to do that in this stage.

@smremde
Copy link
Contributor

smremde commented Oct 27, 2014

Ok - having never maintained a nuget package I wasn't sure of the complexity.

Like you say the advantage is being able to choose the dependency(s). I think you said openTK won't work with WPF at the moment, but if it did, would you include that in the default WPF package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants