Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Mapsui.UI.Blazor.targets for fixing HarfbuzzWasm issue (inspired by Avalonia.Browser) #2103

Merged
merged 3 commits into from Jul 10, 2023

Conversation

inforithmics
Copy link
Contributor

No description provided.

@inforithmics
Copy link
Contributor Author

Workaround works now.
But when .NET 8 is supported the .targets file as to be adapted to include the right harfbuzz library

@inforithmics inforithmics changed the title WIP Adding Mapsui.UI.Blazor.targets for fixing HarfbuzzWasm issue Adding Mapsui.UI.Blazor.targets for fixing HarfbuzzWasm issue Jul 8, 2023
@inforithmics inforithmics changed the title Adding Mapsui.UI.Blazor.targets for fixing HarfbuzzWasm issue Adding Mapsui.UI.Blazor.targets for fixing HarfbuzzWasm issue (inspired by Avalonia.Browser) Jul 8, 2023
Copy link
Member

@pauldendulk pauldendulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to check Avalonia, they have many of the same problems that we have. There could be more suggestions to our problems in their code base. I also wonder how they deal with the GPU rendering problems that we have.


### Troubleshooting

### Text is not displayed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workaround is still here but from the way it is written I assume this is just in case it still is not working. Is that correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. And because the fixed nuget is not released yet maybe I could write that this is for versions lower than 4.0

@pauldendulk pauldendulk merged commit e3ae02a into Mapsui:master Jul 10, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants