Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional wms fixes #2134

Merged
merged 15 commits into from Sep 15, 2023
Merged

Conversation

inforithmics
Copy link
Contributor

Fixes this
#2119
#2130

@inforithmics
Copy link
Contributor Author

Here in this Pull Request, I added an additional Optional Parameter, userAgent.

When you upgrade it still compiles but it is not binary compatible because you have to recompile it.
Should I add an overload with the old parameters. so that it stays Binary compatible ?

@pauldendulk
Copy link
Member

When you upgrade it still compiles but it is not binary compatible because you have to recompile it.
Should I add an overload with the old parameters. so that it stays Binary compatible ?

Good enough when it is not breaking with a recompile.

@pauldendulk pauldendulk merged commit a34cc7d into Mapsui:master Sep 15, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants