Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix touch on Maui/Forms on touch devices #2203

Merged
merged 1 commit into from Oct 8, 2023
Merged

Fix touch on Maui/Forms on touch devices #2203

merged 1 commit into from Oct 8, 2023

Conversation

inforithmics
Copy link
Contributor

doing this by Setting the handled to true if touch is handled

Fixes this

#2197

janusw
janusw approved these changes Oct 8, 2023
View reviewed changes
Copy link
Member

@janusw janusw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that this makes the widgets work again in Mapsui.Samples.Maui.MapView on Android and iOS, and also in Mapsui.Samples.Forms.Android and Mapsui.Samples.Forms.iOS.

So, ok with me, thanks for fixing!

@inforithmics inforithmics merged commit 63c4c15 into Mapsui:master Oct 8, 2023
6 checks passed
@inforithmics inforithmics deleted the FixingWidgetTouchEvents branch October 8, 2023 19:46
@janusw janusw mentioned this pull request Oct 9, 2023
Closed
@pauldendulk pauldendulk changed the title fix: Widget Touch does not work on Maui/Forms on Touch devices Fix touch on Maui/Forms on touch devices Oct 9, 2023
@janusw janusw mentioned this pull request Nov 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janusw janusw janusw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@inforithmics @janusw