Add check for CCW of outer ring and CW for inner rings

[charlenni]

This is regarding #2288.

Checks don't run, even if the resulting image looks totally the same. Could be, that there are problems, because the not solid line around, which could be slightly different from the original one.

[charlenni]

Test don't run, because of the dashed line around. Now the direction is vice versa, so the line looks different from the original test. So it should be updated.

[pauldendulk]

Great fix.

You also reverse the exterior ring to how it is supposed to be, good. I just wondered if this was really required because if it was then I think we would have found out earlier, but I gather from you comment '(if this is the other way around it also seems to work)', I gather that it is not. Weird the inner and outer rings are different in skia.

[charlenni]

Skia needs this to distinguish between outer and inner ring/holes. It seems, that it is only important to have different orientation for holes than for the outer ring.

[pauldendulk]

This fix is also needed for master btw

[charlenni]

Isn't it possible to do this with Git?

[pauldendulk]

I personally do not have a good solution for this. I often just paste the changes in the the other branch. An alternative way is to cherry pick the commits you want to merge to master. This way it is clear this is the exact same change in master and develop, so that is probably better but I don't feel very comfortable working with commit hashes on the command line. What I would like is to have a way in github to say, and now I want this same PR to go to master and do the cherry picking for me. Perhaps that is actually possible, but I could not find this the last time I looked for it.