Add old viewport in ViewportChanged event arguments #2294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry but I have caused conflicts to this PR by merging some big changes. |
|
Solved them |
pauldendulk
approved these changes
Nov 19, 2023
|
But why? I don't see any advantage for this. |
|
You could do a comparison locally with no need to have access to the current viewport, but indeed, there is no real need because there is an alternative solution. So, let's keep it like it is now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, the old Viewport wasn't available after changing some of the settings. With this change, the ViewportChanged event has its own EventArgs, which contain the Viewport from before the change. So it is possible to check, what changed in between.
This is regarding #2280.