Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the v4 build by removing net6.0 from Maui, Uno, Uno.WinUI and iOS #2314

Merged
merged 25 commits into from Dec 4, 2023

Conversation

pauldendulk
Copy link
Member

@pauldendulk pauldendulk commented Dec 3, 2023

With the release of .NET 8 there have been big changes to the gitlab build agents which break the build in many ways without any changes on our side. This PR is the struggle to fix it.

@pauldendulk pauldendulk changed the base branch from master to develop/4.1 December 3, 2023 16:16
@pauldendulk pauldendulk changed the title Fix long press on Xamarin.Forms Android Fix the build Dec 4, 2023
@pauldendulk pauldendulk changed the title Fix the build Fix the build by removing net6.0 from Maui, Uno, Uno.WinUI and iOS Dec 4, 2023
@pauldendulk
Copy link
Member Author

In order to get v4 to build again with the new build agents I did not only had to update the build scripts but also had to remove target frameworks. This is definitely not something you want to do in a patch, but I don't see a way around it:

  • Removed net6.0 from mapsui.UI.Maui
  • Removed net6.0-ios from Mapsui.UI.Uno.WinUI
  • Removed net6.0-ios from mapsui.UI.Uno
  • Removed net6.0-ios15.4 from Mapsui.UI.iOS

@pauldendulk pauldendulk changed the title Fix the build by removing net6.0 from Maui, Uno, Uno.WinUI and iOS Fix the v4 build by removing net6.0 from Maui, Uno, Uno.WinUI and iOS Dec 4, 2023
@pauldendulk pauldendulk merged commit b64056e into develop/4.1 Dec 4, 2023
7 of 8 checks passed
@pauldendulk pauldendulk deleted the feature/fix-long-press branch December 4, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant