Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MapControl code cleanup #2382

Merged
merged 5 commits into from Jan 3, 2024
Merged

MapControl code cleanup #2382

merged 5 commits into from Jan 3, 2024

Conversation

pauldendulk
Copy link
Member

No description provided.

Copy link
Member

@charlenni charlenni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All things make sense. For the last commit I'm not sure about the reason, but it turns things back, so I have no problem with it.

@@ -15,7 +14,7 @@ public partial class MapControl : ComponentBase, IMapControl
public static bool UseGPU { get; set; } = false;

private readonly SKCanvasView? _viewCpu;
private readonly SKGLView? _viewGpu;
protected readonly SKGLView? _viewGpu;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, what the problem was. Do Blazer need access to this fields? Any problems with the samples?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because our Blazor solution uses a MapControlComponent.razor which inherits from the MapControl. The MapControlComponent is what the users should use and not the MapControl. So Blazor is differs from the other platforms in that way. I am not sure if there is another solution, where all code is a MapControl class. At least we could rename MapControlComponent.razor to MapControl.razor and the Blazor base class to something else.

I broke the build inadvertently because I did not have the inheritance clear. Also ctrl+f12 in visual studio does not show the inherited class.

@pauldendulk pauldendulk merged commit 861b236 into main Jan 3, 2024
5 checks passed
@pauldendulk pauldendulk deleted the feature/clean-mapcontrols branch January 3, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants