Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1] Update SkiaSharp to 2.88.7 to fix jpeg creation bugs #2411

Merged
merged 4 commits into from Jan 13, 2024

Conversation

inforithmics
Copy link
Contributor

@inforithmics inforithmics commented Jan 11, 2024

Depends on: #2413

@inforithmics inforithmics changed the title Update SkiaSharp to 2.88.7 Fixes jpeg creation bugs Update SkiaSharp to 2.88.7 Fixes jpeg creation bugs Version 4.1.2 Jan 11, 2024
@pauldendulk
Copy link
Member

This PR has all the changes in it from this PR. That is just fine. It is better to put it in small steps working with PR dependencies. The other PR should be reviewed first. Then this one should be updated.

I wrote something about PR dependencies in the guidelines:
#2420

There is just one this to improve, and that is to mention this dependency in the description (the first comment). ... I will add it right now.

@pauldendulk
Copy link
Member

I merged the previous branch and updates this one. Now I have only one changed file to review. This works well.

Copy link
Member

@pauldendulk pauldendulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this.

@pauldendulk pauldendulk merged commit 4b15038 into Mapsui:develop/4.1 Jan 13, 2024
6 checks passed
@pauldendulk pauldendulk changed the title Update SkiaSharp to 2.88.7 Fixes jpeg creation bugs Version 4.1.2 [4.1] Update SkiaSharp to 2.88.7 to fix jpeg creation bugs Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants