Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1] Add an iteration lock to prevent cross thread operation #2459

Merged
merged 1 commit into from Jan 22, 2024

Conversation

inforithmics
Copy link
Contributor

…me time.

I discovered this during this pull request

#2425

That when SkiaObjects are used in more than one threads exceptions occour. This was the simplest fix to the Skia Crashes. I'll still investigating If I can do without a global Render/Iteration Lock But for the 4.1.2 Branch this should be sufficient to Fix Threading issues.

@inforithmics inforithmics changed the title Add: an iteration Lock so that only one Thread renders at the sa… Add: (4.1.2) an iteration Lock so that only one Thread renders at the sa… Jan 21, 2024
Copy link
Member

@pauldendulk pauldendulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splendid!

@pauldendulk pauldendulk merged commit d634209 into Mapsui:develop/4.1 Jan 22, 2024
6 checks passed
@pauldendulk pauldendulk changed the title Add: (4.1.2) an iteration Lock so that only one Thread renders at the sa… [4.1] Add an iteration lock to prevent cross thread operation Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants