Made Avalonia MapControl's Map property DirectProperty #2481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed styling and thus we can remove necessity to access it in UI thread only. Removed databinding from sample, because it needs a little bit more advanced DI to use (currently we assign DataContext after construction, but constructor needs ViewModel's Map property to initialize)
|
|
pauldendulk
approved these changes
Feb 3, 2024
There was a problem hiding this comment.
Again I can not properly review this and will accept it as is. The link to the documentation is helpful. We value a minimal approach in Mapsui so if a simpler solution suffices this is better. I like the fact that this direct property is now in the Avalonia MapControl and needs no #if.
One question: You do not use data binding in the sample because it would need more changes to the sample, fine. But it is possible to use data binding with the DirectProperty?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made Avalonia MapControl's Map property direct, because it doesn't need styling and thus we can remove necessity to access it in UI thread only.
Using StyledProperty, as it was made in previous PR requires access to Map property through UI thread and it was not really good idea.
DirectProperty, on the other hand, allows us to use existing Map property without any modifications.
(More details can be found here)
Removed databinding from sample, because it needs a little bit more advanced DI to use (currently we assign DataContext after construction, but constructor needs ViewModel's Map property to initialize)