[4.1] Fix panning while mouse is up in Blazor #2505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldendulk
changed the title
pauldendulk
changed the title
pauldendulk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When, while dragging, the mouse goes out of the MapControl area, you lift the mouse button, and hover back over the MapControl again, the map will still be panning. This is because the MouseUp is not detected when the mouse is outside the map. Now we reset the previous position on the MouseOut event.
This type of gesture happens quite a lot when you dragging a long distance.
A better solution would be to use pointer capture, so that you could keep on dragging outside the map, a mouseUp would still be detected when you are out of the map. We have this in other platforms and I like it as a user.