Cleanup guided by changes made in .editorconfig #2517
Conversation
| @@ -252,5 +249,10 @@ insert_final_newline = true | |||
| dotnet_style_prefer_compound_assignment = true:suggestion | |||
| dotnet_code_quality_unused_parameters = all:suggestion | |||
|
|
|||
| ### dotnet_diagnostic | |||
There was a problem hiding this comment.
The .editorconfig settings below had a lot of impact. What I wanted to change was to set 'unused usings' to error because I spend a lot of time fixing that afterwards. This change itself affected a lot of files.
A requirement however was to set GenerateDocumentationFile to true in the Directory.Build.props (seems unrelated but that is how it currently works). This generated a lot of errors on the documentation. It reported real errors, so it is definitely good to have this turned on. It will improve our API documentation. I had to suppress the missing xml comments error (set tot none) because that would be way too much work, also, I don't want it at this point where a lot is still changing.
I moved the fix formatting to group it with the other dotnet_diagnostic entries, en this resulted somehow in many more whitespace errors. Basically it never functioned properly before, even though it did detect quite a few whitespace errors, just not all.
| // _param1 = TargetNs | ||
| // _param2 = Value of the type-attribute | ||
| "//xs:element[_PARAMCOMPWITHTARGETNS_(@type, $_param1, $_param2)]/@name"; | ||
| private static readonly string _XPATH_GEOMETRY_ELEMREF_GEOMNAMEQUERY |
There was a problem hiding this comment.
These .editorconfig changes were found by the server but not on my machine
…apsui/Mapsui into feature/cleanup-based-on-editor-config
Instead the log level could have been changes, I felt in this case this was not necessary anymore, this kind of thing should be in metrics.
pauldendulk
changed the title
pauldendulk
changed the title
No description provided.