Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup MapInfo #2545

Merged
merged 21 commits into from Mar 15, 2024
Merged

Cleanup MapInfo #2545

merged 21 commits into from Mar 15, 2024

Conversation

pauldendulk
Copy link
Member

@pauldendulk pauldendulk commented Mar 11, 2024

  • Make MapInfo non-nullable. This was easy to fix in the core and avoids having to pass the nullable MapInfo to many other method.
  • Use TapType in MapInfo
  • Some renaming from Info to MapInfo, but not yet on the event, perhaps I should rename that as well.
  • Add GetMapInfo() to the WidgetEventArgs to make it easy to call from all events. By adding it as a method it will not affect performance unless users will actually call the GetMapInfo(). I am considering adding a list of layer to query as argument and remove the ILayer.IsInfoLayer.
  • Cleanup LabelsSample.cs (completely unrelated)

@pauldendulk pauldendulk merged commit 7d21c03 into main Mar 15, 2024
5 checks passed
@pauldendulk pauldendulk deleted the feature/getmapinfo branch March 15, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant