-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup MapInfo #2545
Merged
Merged
Cleanup MapInfo #2545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pauldendulk
commented
Mar 11, 2024
•
edited
edited
- Make MapInfo non-nullable. This was easy to fix in the core and avoids having to pass the nullable MapInfo to many other method.
- Use TapType in MapInfo
- Some renaming from Info to MapInfo, but not yet on the event, perhaps I should rename that as well.
- Add GetMapInfo() to the WidgetEventArgs to make it easy to call from all events. By adding it as a method it will not affect performance unless users will actually call the GetMapInfo(). I am considering adding a list of layer to query as argument and remove the ILayer.IsInfoLayer.
- Cleanup LabelsSample.cs (completely unrelated)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.