Replace VertexOnlyLayer with SymbolStyle on all geometries #2553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/vertex-only-style
…into feature/vertex-only-style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
The EditingWidgetSample does not work properly because tapping a vertex only works if you tap within the polygon area, not on the vertices that are partially outside this area. This is because a hit on the vertex is not a hit on the polygon but on the points in the VertexOnlyLayer. By handling this with a style on the polygon no extra logic is needed to make it work as it should.
How
This turned out to be simpler than I thought. Instead of adding a new style and new style renderer I changed the SymbolStyle so that it can be applied to all types. This is done by using IFeature.CoordinateVisitor.
Breaking change
This could change visualization if users have SymbolStyle on a layer that contains polygons and lines as well.