Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: Uno to 5.2 and use single Project for Samples #2609

Merged
merged 42 commits into from May 2, 2024

Conversation

inforithmics
Copy link
Contributor

@inforithmics inforithmics commented Apr 25, 2024

I upgraded to Uno 5.2 and use the new single Project Infrastructure for the Sample, All platforms are now in one project like maui.

  • WinUI
  • Browser
  • Android
  • iOS

Things done:

  1. A lot of Code was removed mainly from the different Uno.WinUI Samples targets
  2. Uno.Check runs now in the github actions so that all Uno dependencies are installed.
  3. Uno Version is now managed in the global.json
 "msbuild-sdks": {
   "Uno.Sdk": "5.2.95"
 }
  1. Skia is referenced with the UnoFeatures
<UnoFeatures>
  Skia;
</UnoFeatures>
  1. Removed .NET 7 Target because .NET 7 is end of Life in 2024 May

@inforithmics inforithmics changed the title WIP Upgrade: Uno to 5.2 and use single Project for Samples Upgrade: Uno to 5.2 and use single Project for Samples Apr 28, 2024
@inforithmics inforithmics changed the title Upgrade: Uno to 5.2 and use single Project for Samples WIP Upgrade: Uno to 5.2 and use single Project for Samples Apr 28, 2024
@inforithmics inforithmics changed the title WIP Upgrade: Uno to 5.2 and use single Project for Samples Upgrade: Uno to 5.2 and use single Project for Samples Apr 28, 2024
Copy link
Member

@pauldendulk pauldendulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great improvement. Lots of files removed. I have a few remarks and questions to look at.

Mapsui.UI.WinUI/Globals.cs Outdated Show resolved Hide resolved
Mapsui.UI.WinUI/MapControl.cs Outdated Show resolved Hide resolved
Samples/Mapsui.Samples.Uno.WinUI/.gitignore Outdated Show resolved Hide resolved
global.json Show resolved Hide resolved
@inforithmics
Copy link
Contributor Author

@pauldendulk I adressed the comments, the "msbuild-sdks": I couldn't move downwards it really needs to be in the global.json file this value is used read by Uno to make make the single project work. It provides the Version Number for all Uno components.

Copy link
Member

@pauldendulk pauldendulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All great. I like all the cleaning up done in the later commits.

@@ -15,7 +15,7 @@ jobs:
steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0
fetch-depth: 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will make the ci/cd faster?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but I had to revert it because package with checkin hash needs history. Until the last version tag.

.github/workflows/dotnet.yml Show resolved Hide resolved
Mapsui.UI.WinUI/MapControl.cs Show resolved Hide resolved
@pauldendulk pauldendulk merged commit 13dd812 into Mapsui:main May 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants