New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade: Uno to 5.2 and use single Project for Samples #2609
Conversation
…uno centralpackage Reference Bug
…aroud a uno centralpackage Reference Bug" This reverts commit efb5e83.
This reverts commit 04f17a7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great improvement. Lots of files removed. I have a few remarks and questions to look at.
@pauldendulk I adressed the comments, the "msbuild-sdks": I couldn't move downwards it really needs to be in the global.json file this value is used read by Uno to make make the single project work. It provides the Version Number for all Uno components. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All great. I like all the cleaning up done in the later commits.
.github/workflows/dotnet.yml
Outdated
@@ -15,7 +15,7 @@ jobs: | |||
steps: | |||
- uses: actions/checkout@v3 | |||
with: | |||
fetch-depth: 0 | |||
fetch-depth: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will make the ci/cd faster?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but I had to revert it because package with checkin hash needs history. Until the last version tag.
I upgraded to Uno 5.2 and use the new single Project Infrastructure for the Sample, All platforms are now in one project like maui.
Things done: