Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]RTF invalid when first row has empty 2nd NAT #76

Closed
vincewu51 opened this issue Jun 20, 2021 · 3 comments · Fixed by #89
Closed

[BUG]RTF invalid when first row has empty 2nd NAT #76

vincewu51 opened this issue Jun 20, 2021 · 3 comments · Fixed by #89
Assignees
Labels
bug Something isn't working

Comments

@vincewu51
Copy link

Describe the bug
When the player in the first row of the RTF has no 2nd NAT, replace faces gives an 'invalid RTF' error. If 2nd NAT is added, the error gives away.

To Reproduce
Use any RTF without 2nd NAT in the first row and click 'replace faces'.

Expected behavior
Finished

Screenshots
image

Desktop (please complete the following information):
windows

Attachments
Add your newgan.log and RTF-File

@vincewu51 vincewu51 added the bug Something isn't working label Jun 20, 2021
@Maradonna90
Copy link
Owner

can you provide the RTF-file?

@Maradonna90 Maradonna90 self-assigned this Jun 25, 2021
@Maradonna90 Maradonna90 added this to the NewGAN-Manager v1.3.0 milestone Jun 25, 2021
@xaser-one
Copy link

Hey, just to add a little more info on this:
The regex in the is_rtf_valid function seems to be too restrictive - it only matches lines with 2 nationalities, meaning if every player in the file only has 1 nationality, the validation fails. Also player names with special chars (dot, dash, apostrophe) never match.

Example on pythex.org

@Maradonna90
Copy link
Owner

@xaser-one good point. Thats should probably solve the problem.

Maradonna90 added a commit that referenced this issue Nov 7, 2021
Maradonna90 added a commit that referenced this issue Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants