Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Infinite loop in colors.js package to be removed. #345

Open
akashchouhan16 opened this issue May 17, 2023 · 1 comment
Open

[Bug] Infinite loop in colors.js package to be removed. #345

akashchouhan16 opened this issue May 17, 2023 · 1 comment

Comments

@akashchouhan16
Copy link

Context
The index.js file of the module has an infinite loop that needs to be removed. It exists in the prod release as well. >=1.4.1
Not sure if it's been a purposeful attempt by the maintainers.
nischi pushed a commit to nischi/cypress-image-diff that referenced this issue May 24, 2023
@nischiemineo
Update colors to @colors/colors
d143536 
Because colors has an issue with an endless loop it will not work with
newer node versions. Marak/colors.js#345
To avoid this endless loop i updated from colors library to newer
@colors/colors library which has fixed this issue.

[fix] update to @colors/colors to fix endless loop in cli
@nischi nischi mentioned this issue May 24, 2023
Merged
nischi pushed a commit to nischi/cypress-image-diff that referenced this issue May 31, 2023
@nischiemineo
feat: update to @colors/colors to fix endless loop in cli
d5220c3 
Because colors has an issue with an endless loop it will not work with
newer node versions. Marak/colors.js#345
To avoid this endless loop i updated from colors library to newer
@colors/colors library which has fixed this issue.
@cinderblock
Copy link

This package is dead. Original author killed it because... well, basically no reason as far as I can tell. You probably want to switch to the @colors/colors package as it seems to be the logical successor to this mess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cinderblock @akashchouhan16