-
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ios): completely rework ios #726
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm |
Malinskiy
force-pushed
the
feature/ios-rework
branch
2 times, most recently
from
January 18, 2023 10:51
cfd89d4
to
e479dfa
Compare
Codecov Report
@@ Coverage Diff @@
## develop #726 +/- ##
=============================================
- Coverage 62.05% 59.27% -2.78%
- Complexity 724 822 +98
=============================================
Files 181 209 +28
Lines 3697 4182 +485
Branches 596 655 +59
=============================================
+ Hits 2294 2479 +185
- Misses 1104 1377 +273
- Partials 299 326 +27
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
simctl io doesn't really support gif even if it advertises that. use jpeg images for combining into gif since they're lightweight and we don't need pixel-perfect here
Malinskiy
force-pushed
the
feature/ios-rework
branch
from
January 22, 2023 10:32
44b6341
to
4413cc7
Compare
This was referenced Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks iOS implementation of testing. Short version of changes:
.app
and.xctest
(including as zip and ipa and derived data dir)and more
Docs are updated in this PR, refer to them for more info, until 0.8.0 they will be at docs.marathonlabs.io/next/ios