Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(marathon-gradle-plugin): fixed groovy filtering configuration #753

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

ildar2
Copy link
Contributor

@ildar2 ildar2 commented Feb 9, 2023

fix #752
fixed Wrapper.toList() so it would fill 'values' for FilterConfigurations if there are more than 1 entry. otherwise it would remain as 'regex'
added a 'fully-qualified-test-name' implementation

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #753 (fac6f27) into develop (6e87c35) will not change coverage.
The diff coverage is n/a.

❗ Current head fac6f27 differs from pull request most recent head 600960f. Consider uploading reports for the commit 600960f to get more accurate results

@@            Coverage Diff             @@
##             develop     #753   +/-   ##
==========================================
  Coverage      59.55%   59.55%           
  Complexity       820      820           
==========================================
  Files            208      208           
  Lines           4285     4285           
  Branches         698      698           
==========================================
  Hits            2552     2552           
  Misses          1406     1406           
  Partials         327      327           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ildar2
Copy link
Contributor Author

ildar2 commented Feb 13, 2023

@Malinskiy let me know if there is something to fix in this pr. I've thought about implementing file filtering, but decided not to stuff it in there.
There are two options I've considered for file:

  1. check if there is a "file:" prefix in filtering config
  2. create a separate config for file

both have their trade offs, but I like the first one better

@Malinskiy
Copy link
Member

@ildar2 thanks a lot for the PR! I'll have time to review this during the weekend, will reply back here if something needs to be changed. From a quick glance - there should be something added to the docs about the behavior here with mapping single filter parameter to regex and multiple parameters to values. I wouldn't bother with file filters since gradle community seems to insist everything should be in xxx.gradle.

@ildar2
Copy link
Contributor Author

ildar2 commented Mar 3, 2023

Hey! How's it going? We pretty much got around this with "test1|test2" regex hack, but it would be easier for others to use marathon with this addition

@Malinskiy Malinskiy merged commit d6a808a into MarathonLabs:develop Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Groovy Filtering issues (and Dynamic configuration)
2 participants