Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): SingleValueTestFilter if file not exist then should be evaluated as empty #776

Merged
merged 8 commits into from
Apr 25, 2023
Merged

fix(core): SingleValueTestFilter if file not exist then should be evaluated as empty #776

merged 8 commits into from
Apr 25, 2023

Conversation

Vacxe
Copy link
Member

@Vacxe Vacxe commented Mar 20, 2023

…te as empty

@Vacxe Vacxe changed the title fix(core): if test filtering files not exist then it should be evalua… fix(core): SingleValueTestFilter if file not exist then should be evaluate as empty Mar 20, 2023
@codecov
Copy link

codecov bot commented Mar 21, 2023 •
edited

Codecov Report

Merging #776 (ceb0067) into develop (04ad70b) will increase coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head ceb0067 differs from pull request most recent head 1b37433. Consider uploading reports for the commit 1b37433 to get more accurate results

@@              Coverage Diff              @@
##             develop     #776      +/-   ##
=============================================
+ Coverage      59.60%   59.69%   +0.08%     
  Complexity       821      821              
=============================================
  Files            208      208              
  Lines           4288     4290       +2     
  Branches         699      699              
=============================================
+ Hits            2556     2561       +5     
+ Misses          1406     1405       -1     
+ Partials         326      324       -2
Impacted Files Coverage Δ
...marathon/execution/filter/SingleValueTestFilter.kt 55.17% <100.00%> (+10.72%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Malinskiy Malinskiy changed the title fix(core): SingleValueTestFilter if file not exist then should be evaluate as empty fix(core): SingleValueTestFilter if file not exist then should be evaluated as empty Apr 18, 2023
@Vacxe Vacxe force-pushed the fix-not-existing-files-logic branch from 6a8f524 to 673e7eb Compare April 25, 2023 00:58
@Vacxe Vacxe force-pushed the fix-not-existing-files-logic branch from 673e7eb to 00d5c8c Compare April 25, 2023 00:59
@Malinskiy Malinskiy merged commit 637331f into MarathonLabs:develop Apr 25, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Malinskiy Malinskiy Malinskiy approved these changes

@tagantroy tagantroy Awaiting requested review from tagantroy tagantroy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Vacxe @Malinskiy