Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): pullFolder shouldn't fail if folder contains empty file #789

Merged
merged 3 commits into from
Apr 25, 2023

Conversation

Malinskiy
Copy link
Member

The pull of empty files can still fail since exists() check for stat verifies the presence of the file by checking the size, permissions and mtime. If all those are 0, the file will be considered non-existent.

Fixes #787

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #789 (964a5bf) into develop (5796f81) will not change coverage.
The diff coverage is n/a.

❗ Current head 964a5bf differs from pull request most recent head 9585725. Consider uploading reports for the commit 9585725 to get more accurate results

@@            Coverage Diff             @@
##             develop     #789   +/-   ##
==========================================
  Coverage      59.65%   59.65%           
  Complexity       824      824           
==========================================
  Files            209      209           
  Lines           4303     4303           
  Branches         702      702           
==========================================
  Hits            2567     2567           
  Misses          1412     1412           
  Partials         324      324           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Malinskiy Malinskiy merged commit c42e945 into develop Apr 25, 2023
11 checks passed
@Malinskiy Malinskiy deleted the fix/android-pull-empty-file branch April 25, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

com.malinskiy.marathon.exceptions.TransferException when trying to pull an empty text file from device.
1 participant