feat(analytics): migrate to grafana cloud #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ga is deprecated implementation is super simple via a single http post request, all metrics are anonymized, behind a flag and turned on by default
Malinskiy
commented
May 3, 2023
|
|
||
| class GrafanaCloud : UsageTracker { | ||
| private val client = OkHttpClient() | ||
| private val key = |
There was a problem hiding this comment.
This key will end up in our sources anyways, don't see any reason to make it harder to extract
Malinskiy
commented
May 3, 2023
| append( | ||
| events.map { event -> | ||
| when (event) { | ||
| is Event.Devices -> Metric(name = "testing.device", value = event.total, tags = tags) |
Malinskiy
commented
May 3, 2023
| events.map { event -> | ||
| when (event) { | ||
| is Event.Devices -> Metric(name = "testing.device", value = event.total, tags = tags) | ||
| is Event.Executed -> Metric(name = "testing.duration", value = event.seconds, tags = tags) |
There was a problem hiding this comment.
total duration of tests
Malinskiy
commented
May 3, 2023
| when (event) { | ||
| is Event.Devices -> Metric(name = "testing.device", value = event.total, tags = tags) | ||
| is Event.Executed -> Metric(name = "testing.duration", value = event.seconds, tags = tags) | ||
| is Event.TestsTotal -> Metric(name = "testing.test", value = event.total, tags = tags) |
There was a problem hiding this comment.
number of tests before filtering
Malinskiy
commented
May 3, 2023
| is Event.Devices -> Metric(name = "testing.device", value = event.total, tags = tags) | ||
| is Event.Executed -> Metric(name = "testing.duration", value = event.seconds, tags = tags) | ||
| is Event.TestsTotal -> Metric(name = "testing.test", value = event.total, tags = tags) | ||
| is Event.TestsRun -> Metric(name = "testing.executed", value = event.value, tags = tags) |
There was a problem hiding this comment.
number of tests after filtering
Codecov Report
@@ Coverage Diff @@
## develop #792 +/- ##
=============================================
- Coverage 59.84% 59.24% -0.60%
Complexity 790 790
=============================================
Files 209 213 +4
Lines 4303 4380 +77
Branches 679 689 +10
=============================================
+ Hits 2575 2595 +20
- Misses 1412 1463 +51
- Partials 316 322 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@Malinskiy Codecov plugin in the PR is so annoying and distracts me from reviewing the code. Could you turn it off in the code page? |
matzuk
reviewed
May 7, 2023
| @@ -15,7 +15,7 @@ class MarathonRunCommonOptions : OptionGroup() { | |||
| .default(File("Marathonfile")) | |||
| val analyticsTracking by option("--analyticsTracking", help="Enable anonymous analytics tracking") | |||
| .convert { it.toBoolean() } | |||
| .default(false) | |||
| .default(true) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reason: GA is deprecated
notes: implementation is super simple via a single HTTP post request. All metrics are anonymized, behind a flag and turned on by default