feat(core):change flakiness overhead from ms to readable format #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #793 +/- ##
=============================================
- Coverage 59.26% 59.25% -0.02%
- Complexity 791 793 +2
=============================================
Files 213 213
Lines 4380 4378 -2
Branches 689 689
=============================================
- Hits 2596 2594 -2
Misses 1462 1462
Partials 322 322
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Vacxe
force-pushed
the
feature-core-update-flakiness-overhead-time
branch
4 times, most recently
from
7bd9eca
to
f8394ed
Compare
Malinskiy
previously approved these changes
May 9, 2023
|
|
…com:Vacxe/marathon into feature-core-update-flakiness-overhead-time
Vacxe
force-pushed
the
feature-core-update-flakiness-overhead-time
branch
from
5c470e0
to
3fff539
Compare
Vacxe
commented
May 10, 2023
| @@ -72,7 +72,7 @@ data class ExecutionReport( | |||
| val rawDuration = rawTests | |||
| //Incomplete tests mess up the calculations of time since their end time is 0 and duration is, hence, years | |||
| //We filter here for unavailable time just to be safe | |||
| .filter { it.startTime != 0L && it.endTime != 0L } | |||
There was a problem hiding this comment.
Or will be better to filter endTime - startTime > 0 ? WDYT @Malinskiy
Vacxe
force-pushed
the
feature-core-update-flakiness-overhead-time
branch
from
3fff539
to
78e478b
Compare
Malinskiy
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.