fix(core): propagate meta properties into final TestResult #875

matzuk · 2023-12-08T14:37:08Z

No description provided.

codecov · 2023-12-08T15:03:00Z

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (a4ea2c1) 59.31% compared to head (15e6739) 59.30%.

Files	Patch %	Lines
...thon/execution/progress/PoolProgressAccumulator.kt	76.92%	0 Missing and 3 partials ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             develop     #875      +/-   ##
=============================================
- Coverage      59.31%   59.30%   -0.02%     
  Complexity       798      798              
=============================================
  Files            214      214              
  Lines           4437     4443       +6     
  Branches         707      709       +2     
=============================================
+ Hits            2632     2635       +3     
  Misses          1476     1476              
- Partials         329      332       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Malinskiy · 2023-12-12T00:12:06Z

core/src/main/kotlin/com/malinskiy/marathon/execution/progress/PoolProgressAccumulator.kt

-    shard: TestShard,
-    private val configuration: Configuration,
+    val shard: TestShard,
+    val configuration: Configuration,


why the change to public?

Where? I still see val configuration: Configuration,

Please check the file. You see the outdated information (GitHub specific).

…r if a user forgot to add the correspondent dependency in the project

…roducer)" This reverts commit 5ea2261.

This reverts commit 0c65cbe.

… listener if a user forgot to add the correspondent dependency in the project" This reverts commit f4bc58c.

…eta_2

fix(core): meta properties are in final TestResult

cad1958

matzuk requested review from Malinskiy, tagantroy and Vacxe as code owners December 8, 2023 14:37

Malinskiy requested changes Dec 12, 2023

View reviewed changes

matzuk added 8 commits December 12, 2023 07:09

fix(core): pr fixes

36a5b8a

fix(android_parsing): remote parse without overridden testrun listene…

f4bc58c

…r if a user forgot to add the correspondent dependency in the project

fix(android_parsing): change overrides only when test run fails

0c65cbe

fix(android_parsing): check overrides value too (annotation producer)

5ea2261

Revert "fix(android_parsing): check overrides value too (annotation p…

a4508ae

…roducer)" This reverts commit 5ea2261.

Revert "fix(android_parsing): change overrides only when test run fails"

ae9f1c2

This reverts commit 0c65cbe.

Revert "fix(android_parsing): remote parse without overridden testrun…

57589ca

… listener if a user forgot to add the correspondent dependency in the project" This reverts commit f4bc58c.

Merge remote-tracking branch 'origin/develop' into feature/raw_json_m…

c1dd57f

…eta_2

Malinskiy force-pushed the develop branch from 57589ca to 0106217 Compare January 9, 2024 12:34

Merge branch 'develop' into feature/raw_json_meta_2

15e6739

Malinskiy changed the title ~~fix(core): meta properties are in final TestResult~~ fix(core): propagate meta properties into final TestResult Jan 22, 2024

Malinskiy merged commit 953ad17 into develop Jan 22, 2024
10 of 11 checks passed

Malinskiy deleted the feature/raw_json_meta_2 branch January 22, 2024 11:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(core): propagate meta properties into final TestResult #875

fix(core): propagate meta properties into final TestResult #875

matzuk commented Dec 8, 2023

codecov bot commented Dec 8, 2023 •

edited

Malinskiy Dec 12, 2023

matzuk Dec 12, 2023

Malinskiy Dec 12, 2023

matzuk Dec 12, 2023

fix(core): propagate meta properties into final TestResult #875

fix(core): propagate meta properties into final TestResult #875

Conversation

matzuk commented Dec 8, 2023

codecov bot commented Dec 8, 2023 • edited

Codecov Report

Malinskiy Dec 12, 2023

Choose a reason for hiding this comment

matzuk Dec 12, 2023

Choose a reason for hiding this comment

Malinskiy Dec 12, 2023

Choose a reason for hiding this comment

matzuk Dec 12, 2023

Choose a reason for hiding this comment

codecov bot commented Dec 8, 2023 •

edited