Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): fix ConcurrentModificationException in AdamAndroidDevice #883

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

Malinskiy
Copy link
Member

@Malinskiy Malinskiy commented Jan 23, 2024

Listeners for log messages are mostly loaded by traversal and modifications are performed before and after each test batch, so copy-on-write implementation makes more sense. synchronized block is implemented by the class itself making synchronization in the adam device redundant

Closes #882

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (953ad17) 59.30% compared to head (ac8d57f) 59.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #883   +/-   ##
==========================================
  Coverage      59.30%   59.30%           
  Complexity       798      798           
==========================================
  Files            214      214           
  Lines           4443     4443           
  Branches         709      709           
==========================================
  Hits            2635     2635           
  Misses          1476     1476           
  Partials         332      332           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Malinskiy Malinskiy merged commit 9156f36 into develop Jan 23, 2024
11 checks passed
@Malinskiy Malinskiy deleted the fix/adam-device-concurrent-line-listeners branch January 23, 2024 09:57
Malinskiy added a commit that referenced this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConcurrentModificationException in LogcatManager
1 participant