Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(configuration): allow ANY_SUCCESS and count sharding strategy wit… #888

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

Malinskiy
Copy link
Member

@Malinskiy Malinskiy commented Feb 1, 2024

…h count 1

Really miss https://doc.rust-lang.org/book/ch06-02-match.html in Kotlin

Closes #887

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (c6465a8) 59.31% compared to head (8ad6eed) 59.27%.

Files Patch % Lines
...y/marathon/config/LogicalConfigurationValidator.kt 0.00% 6 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #888      +/-   ##
=============================================
- Coverage      59.31%   59.27%   -0.04%     
  Complexity       799      799              
=============================================
  Files            214      214              
  Lines           4451     4454       +3     
  Branches         710      711       +1     
=============================================
  Hits            2640     2640              
- Misses          1478     1481       +3     
  Partials         333      333              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Malinskiy Malinskiy merged commit d81a946 into develop Feb 1, 2024
9 of 11 checks passed
@Malinskiy Malinskiy deleted the fix/sharding-1 branch February 1, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Treat sharding count 1 and "ANY SUCCESS" as if sharding was off
1 participant