Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apple): rework apple to support more than just ios #901

Merged
merged 36 commits into from
Mar 12, 2024

Conversation

Malinskiy
Copy link
Member

@Malinskiy Malinskiy commented Feb 16, 2024

Adds support for all simulated Apple devices + macOS

watchOS:
Screenshot_20240221_223010
tv:
Screenshot_20240221_224700
vision pro:
Screenshot_20240221_225611
recording is purely for fun since vision pro only supports xctest

Did I hear someone say macOS?

# Conflicts:
#	vendor/vendor-apple/base/src/main/kotlin/com/malinskiy/marathon/apple/xctestrun/TestRootFactory.kt
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: Patch coverage is 25.62500% with 119 lines in your changes are missing coverage. Please review.

Project coverage is 58.31%. Comparing base (1fc058b) to head (328826b).
Report is 2 commits behind head on develop.

Files Patch % Lines
...athon/config/serialization/ConfigurationFactory.kt 3.33% 29 Missing ⚠️
...hon/analytics/external/influx2/InfluxDb2Tracker.kt 0.00% 21 Missing ⚠️
...skiy/marathon/config/vendor/VendorConfiguration.kt 17.39% 19 Missing ⚠️
...onfig/vendor/apple/AppleTestBundleConfiguration.kt 40.00% 10 Missing and 5 partials ⚠️
...marathon/analytics/external/MetricsProviderImpl.kt 36.36% 5 Missing and 2 partials ⚠️
...fig/vendor/apple/macos/PermissionsConfiguration.kt 0.00% 6 Missing ⚠️
...alinskiy/marathon/config/AnalyticsConfiguration.kt 33.33% 4 Missing ⚠️
...lization/yaml/GraphiteConfigurationDeserializer.kt 0.00% 4 Missing ⚠️
...athon/analytics/external/MetricsProviderFactory.kt 0.00% 3 Missing ⚠️
...marathon/exceptions/IncompatibleDeviceException.kt 0.00% 3 Missing ⚠️
... and 6 more
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #901      +/-   ##
=============================================
- Coverage      59.24%   58.31%   -0.93%     
- Complexity       802      812      +10     
=============================================
  Files            214      217       +3     
  Lines           4468     4568     +100     
  Branches         717      743      +26     
=============================================
+ Hits            2647     2664      +17     
- Misses          1481     1557      +76     
- Partials         340      347       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Malinskiy Malinskiy merged commit 0270d21 into develop Mar 12, 2024
9 of 11 checks passed
@Malinskiy Malinskiy deleted the feature/apple branch March 12, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant