feat(core): add filter disabling thought config #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vacxe
force-pushed
the
add-filter-disabling
branch
2 times, most recently
from
131de5b
to
5a30724
Compare
|
POC: Don't like |
Malinskiy
reviewed
May 22, 2024
| @@ -20,7 +28,7 @@ class AllureTestFilter(val cnf: TestFilterConfiguration.AllureFilterConfiguratio | |||
| } | |||
| } | |||
|
|
|||
| override fun filter(tests: List<Test>): List<Test> { | |||
| override fun filterPredicate(tests: List<Test>): List<Test> { | |||
There was a problem hiding this comment.
Predicate returns bool, this function is not a predicate
Malinskiy
reviewed
May 22, 2024
| import com.malinskiy.marathon.execution.TestFilter | ||
| import com.malinskiy.marathon.test.Test | ||
|
|
||
| interface ToggleTestFilter : TestFilter { |
There was a problem hiding this comment.
Just change the TestFilter to a base class and add this logic there
Vacxe
force-pushed
the
add-filter-disabling
branch
from
5a30724
to
4a50a78
Compare
Vacxe
force-pushed
the
add-filter-disabling
branch
from
4a50a78
to
48bb1ba
Compare
Malinskiy
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.