Fix FP16 bitcasts for ClangCL on ARM/ARM64 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Maratyszcza
requested changes
May 13, 2024
When using ClangCL _MSC_VER is defined just like for MSVC but intrin.h is missing. Adding not defined(__clang__) was required to distinct MSVC and ClangCL.
StefanStojanovic
force-pushed
the
mefi-clang-cl-fix
branch
from
d8bd560
to
b1c5d2a
Compare
Maratyszcza
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using ClangCL
_MSC_VERis defined just like for MSVC butintrin.his missing. Adding&& not defined(__clang__)was required to distinct MSVC and ClangCL.I've noticed this issue when working on adding support for ClangCL for Node.js. The V8 engine, one of its dependencies has FP16 as a dependency of its own.
I've tested these changes with both MSVC and ClangCL and the compilation passed.