Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parsing of storyboards #1

Merged
merged 2 commits into from Mar 12, 2019
Merged

Conversation

benob
Copy link

@benob benob commented Nov 30, 2018

The format for getting storyboards seems to have changed. They are now available in the 'player_response' field.

I checked with master@rg3/youtube-dl that it works.

The format for getting storyboards seems to have changed. They are now available in the 'player_response' field.
@MarcAbonce
Copy link
Owner

Hi. Sorry for the delay.
It looks like YouTube changed the way they return storyboard urls again. When I try to run your branch, I get an error because the storyboards are not found in player_response either.

@benob
Copy link
Author

benob commented Dec 18, 2018

After investigation, it only seems to work for a subset of videos.

  • Example of working video: X5oD_thIk3c
  • Example of non-working video: Iytbx7IGKCM
    It fails if 'storyboards' is not in player_response at line 1514 but fixing that doesn't get storyboards from the non-working videos.

I also get better results for the non-working video when applying my patch to master but still no storyboards.

I can't find the jpeg filenames in the downloaded data, but maybe I am looking at the wrong place. Do you have ideas?

@MarcAbonce MarcAbonce merged commit bb841bb into MarcAbonce:storyboards Mar 12, 2019
@MarcAbonce
Copy link
Owner

You were right.
For the videos where it failed, I found that when the storyboards are not in player_response, you can still find them in a script inside the web page itself.
Now this should work with all videos.
Thank you so much!

MarcAbonce added a commit that referenced this pull request Mar 1, 2021
Storyboards are grids of small images that appear when
the user hovers their cursor over a video's timeline.
See related issue ytdl-org#9868.

Options added:
  * --list-storyboards
  * --write-storyboards

Co-authored by @benob (See: #1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants