Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#71 add post-execute-condition #243

Merged
merged 13 commits into from
Mar 2, 2024
Merged

#71 add post-execute-condition #243

merged 13 commits into from
Mar 2, 2024

Conversation

MarcGiffing
Copy link
Owner

No description provided.

@MarcGiffing MarcGiffing added this to the 0.11.0 milestone Feb 26, 2024
@MarcGiffing MarcGiffing linked an issue Feb 26, 2024 that may be closed by this pull request
execute-condition not working correctly when using UsernamePasswordAuthenticationFilter #71
Closed
@MarcGiffing MarcGiffing marked this pull request as draft February 26, 2024 17:58
@cjacky475
Copy link

@MarcGiffing, I could test this on my app, but could you add a JAR artifact via @actions/upload-artifact?

@MarcGiffing
#71 add post-execute-condition
75f7467 
reduce code duplication for tests (not optimal but it improves maintainability)
@MarcGiffing
#71 add post-execute-condition
937e5b0 
prepare snapshot release
@MarcGiffing
#71 add post-execute-condition
a45d623 
fix wrong directory for general-tests
@MarcGiffing
Copy link
Owner Author

MarcGiffing commented Feb 27, 2024 •
edited

@MarcGiffing, I could test this on my app, but could you add a JAR artifact via @actions/upload-artifact?

I've released a SNAPSHOT version: 0.11.0-SNAPSHOT

This test assures the post-execution filter:
https://github.com/MarcGiffing/bucket4j-spring-boot-starter/blob/a45d6237f629167998d67b5920c7f6e23808835d/examples/general-tests/src/main/java/com/giffing/bucket4j/spring/boot/starter/general/tests/filter/servlet/PostExecuteConditionTest.java

@MarcGiffing
#71 add post-execute-condition
efae5f4
@MarcGiffing
github actions test report
baddd1d
@MarcGiffing
#71 add post-execute-condition
c5b5636 
minor refactoring
add empty response body test
@MarcGiffing
Merge remote-tracking branch 'origin/feature/#71-post-execution-check…
5caf0de 
…' into feature/#71-post-execution-check
@MarcGiffing
#71 add post-execute-condition
6c43898 
tests:
- change response status code
- additional response headers
@MarcGiffing MarcGiffing marked this pull request as ready for review February 28, 2024 19:00
@MarcGiffing
#71 add post-execute-condition
c2c261f 
tests:
- skip condition
@MarcGiffing MarcGiffing self-assigned this Feb 28, 2024
@cjacky475
Copy link

Where is that 0.11.0-SNAPSHOT file? I couldn't find it.

@MarcGiffing
Copy link
Owner Author

Where is that 0.11.0-SNAPSHOT file? I couldn't find it.

https://s01.oss.sonatype.org/content/repositories/snapshots/com/giffing/bucket4j/spring/boot/starter/

You can add the snapshot repository to you pom

<repository>
    <id>nexus</id>
    <name>nexus-snapshot</name>
    <url>https://s01.oss.sonatype.org/content/repositories/snapshots/</url>
    <snapshots>
        <enabled>true</enabled>
    </snapshots>
    <releases>
        <enabled>false</enabled>
    </releases>
</repository>

@MarcGiffing
#71 add post-execute-condition
bccf7d5 
tests:
- execute condition
@MarcGiffing MarcGiffing merged commit 9bf6cd0 into master Mar 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MarcGiffing MarcGiffing

Labels
None yet
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.

execute-condition not working correctly when using UsernamePasswordAuthenticationFilter
2 participants
@MarcGiffing @cjacky475