Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial upload stream example app #22

Merged
merged 1 commit into from Feb 5, 2020

Conversation

R-fred
Copy link
Contributor

@R-fred R-fred commented Jan 15, 2020

No description provided.

@MarcSkovMadsen
Copy link
Owner

Hi @R-fred . Thanks so much. I will take a look ASAP.

@MarcSkovMadsen MarcSkovMadsen merged commit cacc791 into MarcSkovMadsen:master Feb 5, 2020
@MarcSkovMadsen
Copy link
Owner

Hi @R-fred

Sorry for not getting back sooner.

I've been contributing to the release of Panel 0.8.0 and updating the site awesome-panel.org.

Now I have the time. You contribution is awesome. I've played around with it and merged it to my master branch.

There are some things I will like to suggest

  • In the deployed version at awesome-streamlit.org I would like to avoid users creating applications as they could potentially tamper the existing code. So could the app see if the "AWESOME_STREAMLIT_ORG" environment variable is exists. If yes then the new app is not created instead a st.info informs the user what would have happened?
  • I can see that if the directory already exists an error is triggered. This should be handled.
    image
  • Then I think this should be moved into the associated package such that the users can use it via the awesome-streamlit python package.

What do you think?

@MarcSkovMadsen
Copy link
Owner

MarcSkovMadsen commented Feb 5, 2020

I've announced the contribution in the change log.

https://discuss.streamlit.io/t/awesome-streamlit-org-change-log/1414/14

@R-fred
Copy link
Contributor Author

R-fred commented Feb 6, 2020

Hi @R-fred
Sorry for not getting back sooner.
I've been contributing to the release of Panel 0.8.0 and updating the site awesome-panel.org.
Now I have the time. You contribution is awesome. I've played around with it and merged it to my master branch.
There are some things I will like to suggest

In the deployed version at awesome-streamlit.org I would like to avoid users creating applications as they could potentially tamper the existing code. So could the app see if the "AWESOME_STREAMLIT_ORG" environment variable is exists. If yes then the new app is not created instead a st.info informs the user what would have happened?
I can see that if the directory already exists an error is triggered. This should be handled.

Then I think this should be moved into the associated package such that the users can use it via the awesome-streamlit python package.

What do you think?

Hi Marc,
Yeah, that makes sense. I'll make the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants