Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

GetLatestVimScripts support #65

Open
ZyX-I opened this Issue · 5 comments

2 participants

Nikolai Aleksandrovich Pavlov Marc Weber
Nikolai Aleksandrovich Pavlov
Collaborator

As shipped with vim GetLatestVimScripts plugin has support for dependencies doesn’t it make sense to write enabled by default global post-install and post-update hook that will generate addon-info.json file out of GLVS-targeted comments in case it is missing.

It may also make sense to check whether addon-info.json contents (only dependency section, of course) matches GLVS-targeted comments in case it was added by db/patch.vim.

As another solution I can try to write an addition to the cron job script which will install all plugins, check them for comments and thus populate db/glvs.json file which is to be merged with db/patch.vim. I do not want this much because I am unsure that nobody has added something like “zip bomb” to the plugins.

Marc Weber
Owner
Nikolai Aleksandrovich Pavlov
Collaborator

In the end I'm not interested in supporting everything which could be
supported.

This is why it is a hook even though hook does launch after info file is read. This will apply at next restart.

I didn't know that. How do those dependency comments look like?

" GetLatestVimScripts: 884  1 :AutoInstall: AutoAlign.vim

“884” is a script number and it is what matters. “AutoAlign.vim” is a comment, “:AutoInstall:” can be ignored (if I got it right it indicates whether installation should be performed manually due to some issues like requirements to run “ruby extconfig.rb”). More data at :h glvs-data.

On the other hand it looks like support can be added easily if names
of dependencies can be mapped to our names easily.

As you see above there are no relevant names, only numbers. And that can be mapped easily.

Marc Weber
Owner
Marc Weber
Owner
Nikolai Aleksandrovich Pavlov
Collaborator

It already runs before activation, in vam#install#Install. Though in this case one probably has to allow user hooks (those that are stored in g:vim_addon_manager) run after installation no matter whether opts.run_install_hooks is true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.