Need to fix some minor fixes #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing duplicated line line 614 _makeRoundtrip has to return if isDone is complete before setting the pause value, otherwise the fading (if setted) will be painted after last scroll's pause and so the _roundCounter incrementation has to be done before the pause. Also, we need to check that the widget is mounted before the setState otherwise it will produce an error at dipose()
|
I faced another issue, whenever the Marquee makes a round, the fade is gone for a second and it results into this:
If I set showFadingOnlyWhenScrolling to false, its not happening. Just wondering if that is the desired behavior or not. |
MarcelGarus
approved these changes
Jun 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicated line, line 614, sorry about that, the pause was executed twice.
We need to check that the widget is mounted before the setState otherwise it will produce the
Unhandled exception: SetState() called after disposeAlso, _makeRoundTrip has to return before the setState() if isDone is set to true, otherwise the edges will fade (if settled) after the pause
Pubspec.yaml version and Changelog have been updated
Thank you