Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement looping integer list view #32

Merged
merged 5 commits into from
Jan 16, 2019
Merged

Implement looping integer list view #32

merged 5 commits into from
Jan 16, 2019

Conversation

mathieupost
Copy link
Contributor

Solves #11

@coveralls
Copy link

coveralls commented Jan 5, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 14

  • 42 of 43 (97.67%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+4.4%) to 71.831%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/numberpicker.dart 42 43 97.67%
Files with Coverage Reduction New Missed Lines %
lib/numberpicker.dart 1 71.83%
Totals Coverage Status
Change from base Build 7: 4.4%
Covered Lines: 153
Relevant Lines: 213
💛 - Coveralls

MarcinusX
MarcinusX requested changes Jan 6, 2019
View reviewed changes
Copy link
Owner

@MarcinusX MarcinusX left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey man! Thanks for the contribution!
I've reviewed your PR and only one thing bothers me, could you fix it the itemCount field please? :)
After that I will merge and publish it :)
Thank you again!!! <3

MarcinusX
MarcinusX requested changes Jan 6, 2019
View reviewed changes
lib/numberpicker.dart Outdated Show resolved Hide resolved
@mathieupost
Copy link
Contributor Author

Sure! I'll take a look probably tomorrow ;)

@mathieupost
Copy link
Contributor Author

Fixed it!

@MarcinusX
Copy link
Owner

Just noticed that on iOS, overscroll goes out of bound, when you scroll over 0, it gets to 10 for a while :(

@mathieupost
Copy link
Contributor Author

mathieupost commented Jan 9, 2019 via email •
edited
Loading

@mathieupost
Copy link
Contributor Author

Fixed ;)

@MarcinusX MarcinusX merged commit 2ca7d95 into MarcinusX:master Jan 16, 2019
@MarcinusX
Copy link
Owner

Thank you for your contribution and patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcinusX MarcinusX MarcinusX requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mathieupost @coveralls @MarcinusX