Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updating pr persists gh verified status #1459

Merged
merged 2 commits into from
May 12, 2024

Conversation

zvolin
Copy link
Contributor

@zvolin zvolin commented May 12, 2024

When updating PR on github, force push the rebased branch first and create commit through API to keep the verified status of the commit.

Fixes #1406

@zvolin
Copy link
Contributor Author

zvolin commented May 12, 2024

I'll undraft after I test it

@zvolin
Copy link
Contributor Author

zvolin commented May 12, 2024

Tested it manually (but with auto signing disabled) zvolin/test-release-plz#5

@zvolin zvolin marked this pull request as ready for review May 12, 2024 09:58
@MarcoIeni MarcoIeni merged commit f3cc259 into MarcoIeni:main May 12, 2024
13 checks passed
@release-plz release-plz bot mentioned this pull request May 12, 2024
@zvolin zvolin deleted the fix/github-pr-update branch May 12, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

release-pr rebase looses verified status
2 participants