-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(backend): GitLab on-premise support and multilevel URLs, SSH git repos #1521
Conversation
mbodmer
commented
Jun 13, 2024
•
edited
Loading
edited
- Add support for on-premise hosted GitLab, not only gitlab.com
- Add support for SSH git repositories -> will be converted to "https" API URL
- Add support for multi level gitlab groups
- Respect upper case PRIVATE-TOKEN header
- Mark PRIVATE-TOKEN header value as sensitive
- fix bug: release-plz release fails when no "-o json" given as argument
2cf01bf
to
2cbb619
Compare
Sorry, I have made a mess with git. Have now force pushed again and fixed the last clippy warning |
- keep http/https scheme from git repo - convert ssh scheme into https - introduce url encoded project identification Signed-off-by: Marc Bodmer <marc.bodmer@securiton.ch>
Signed-off-by: Marc Bodmer <marc.bodmer@securiton.ch>
Signed-off-by: Marc Bodmer <marc.bodmer@securiton.ch>
Signed-off-by: Marc Bodmer <marc.bodmer@securiton.ch>
Signed-off-by: Marc Bodmer <marc.bodmer@securiton.ch>
CommitParent is not used anywhere, maybe remove it? Signed-off-by: Marc Bodmer <marc.bodmer@securiton.ch>
Would you mind approving the builds? Or is there anything i can do? |
Done! I'll review this asap |
I extracted your fix in #1528 because I wanted to merge it asap, thanks! |
I tested this, and I got the error:
|
yes, the project Name is URL encoded, so 2%F is correct for the "/". Also you have to chose Maintainer role or any role with permission to create MR, for the token. |
I'll test again, thanks! |
You seem to have a solution in mind, just go for it |