Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable progressbar option #37

Merged
merged 3 commits into from
Dec 8, 2020
Merged

Disable progressbar option #37

merged 3 commits into from
Dec 8, 2020

Conversation

cdurth
Copy link
Contributor

@cdurth cdurth commented Nov 22, 2020

PR will implement #32 feature request for option to disable progressbar

@cdurth cdurth mentioned this pull request Nov 22, 2020
Open
@MarcoPNS MarcoPNS self-requested a review December 8, 2020 08:57
MarcoPNS
MarcoPNS requested changes Dec 8, 2020
View reviewed changes
Copy link
Owner

@MarcoPNS MarcoPNS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! But I would like to change "Disabled" to "Off" because I can imagine that some people understand it wrong.

@MarcoPNS MarcoPNS merged commit 6d857f4 into MarcoPNS:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoPNS MarcoPNS MarcoPNS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cdurth @MarcoPNS