Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileHelperEngine ReadStream closes the stream, although the documentation says otherwise #416

Closed
ueli-werner opened this issue Jan 31, 2022 · 0 comments · Fixed by #425
Closed

Comments

@ueli-werner
Copy link

Doc: "This method only uses the stream and does not close them after using it, you must do it."

In version 2.0.0 this was the behavior. Now in version 3.5.1 the stream is closed. Unclear if the behavior change was intentional or not. Either update the documentation or change the behavior.

If it was intentional it is a breaking change.

FileHelpers.dll!FileHelpers.ForwardReader.Close() Line 153 C#
FileHelpers.dll!FileHelpers.ForwardReader.System.IDisposable.Dispose() Line 162 C#
FileHelpers.dll!FileHelpers.FileHelperEngine.ReadStreamAsList(System.IO.TextReader reader = {System.IO.StreamReader}, int maxRecords = 2147483647, System.Data.DataTable dt = null) Line 304 C#
FileHelpers.dll!FileHelpers.FileHelperEngine.ReadStream(System.IO.TextReader reader = {System.IO.StreamReader}, int maxRecords = 2147483647) Line 131 C#
FileHelpers.dll!FileHelpers.FileHelperEngine.ReadStream(System.IO.TextReader reader = {System.IO.StreamReader}) Line 123 C#

mcavigelli added a commit that referenced this issue Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant