ExcelNPOIStorage - Spreadsheets with blank cells

[jiffgithub]

ExtractRecords - Fix Exception index was outside the bounds of the array

The MissingCellPolicy in NPOI library is set to MissingCellPolicy.RETURN_NULL_AND_BLANK by default on both the HSSFWorkbook and XSSFWorkbook classes.

Changing the value to MissingCellPolicy.CREATE_NULL_AS_BLANK on the relevant Workbook instance resolves the issue.

FileHelpers.ExcelNPOIStorage
ExcelNPOIStorage.cs (OpenWorkbook method)
Fix on Line 101

[steffanv]

I found this, because I have to deal with spreadsheets that contain empty cells.

The proposed fix works for me. Unfortunately, I had to build the project on my own so please merge the fix for the next release.

[thatsjohnson]

I also found this issue and verified the fix resolves the problem. Can this be escalated? FileHelpers is an incredibly helpful library and would benefit from this change. The 3.4 version still has this issue and would be very helpful to have fix in a official release. Thank you.

[mcavigelli]

Hi there

Thank you for your code. I see that this looks like a small change.
However we need to have a unittest to verify the changed behaviour.
Would that be possible for you?

Thank you, Matthias

[thatsjohnson]

Of course, I will work on that this week. Chris J

…

On Tue, Jul 9, 2019 at 8:28 AM Matthias Cavigelli ***@***.***> wrote: Hi there Thank you for your code. I see that this looks like a small change. However we need to have a unittest to verify the changed behaviour. Would that be possible for you? Thank you, Matthias — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#291?email_source=notifications&email_token=AESRUAGOBTEUWOA3LJQTPRDP6R763A5CNFSM4EZ7RNK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZQDNVY#issuecomment-509621975>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AESRUAH336WB4UPFLUHYSOTP6R763ANCNFSM4EZ7RNKQ> .

[steffanv]

Of course, I will work on that this week. Chris J
…
On Tue, Jul 9, 2019 at 8:28 AM Matthias Cavigelli @.***> wrote: Hi there Thank you for your code. I see that this looks like a small change. However we need to have a unittest to verify the changed behaviour. Would that be possible for you? Thank you, Matthias — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#291?email_source=notifications&email_token=AESRUAGOBTEUWOA3LJQTPRDP6R763A5CNFSM4EZ7RNK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZQDNVY#issuecomment-509621975>, or mute the thread https://github.com/notifications/unsubscribe-auth/AESRUAH336WB4UPFLUHYSOTP6R763ANCNFSM4EZ7RNKQ .

Dear all,

I have already done this yesterday. Please refer to Pull Request #354 (Spreadsheets with blank cells and Unit Test. #354). This one is also based on the latest code base. Thus it is easy to merge.

Steffan

[mcavigelli]

Thank you for your contribution!
Your requested change is contained in #352

Matthias