Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Use .cleanContent instead of .content #379

Merged
merged 1 commit into from
Mar 29, 2023
Merged

馃悰 Use .cleanContent instead of .content #379

merged 1 commit into from
Mar 29, 2023

Conversation

n1ckoates
Copy link
Contributor

This pull request replaces message.content with message.cleanContent in the thread creation process, which resolves mentions to their actual text.

Only needed to change one line, which feels like it shouldn't "just work", but I think it does.

@MarcusOtter
Copy link
Owner

Sorry - I haven't forgotten about this! I just haven't had time to fully test the feature & differences locally. Should have more free time this summer as I've said in Discord 馃槃 Very grateful for your help!

@n1ckoates
Copy link
Contributor Author

All good, merge when you can :)

Copy link
Owner

@MarcusOtter MarcusOtter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it and it seems to work to me! Worst case we can revert馃槃 As I briefly mentioned before this may break custom regexes that rely on numbers in mentions but I hope that people don't rely on that. Thank you!

@MarcusOtter MarcusOtter merged commit 0830929 into MarcusOtter:main Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

馃挕 Don't show IDs in title
2 participants