Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.4 support #16

Merged
merged 3 commits into from Dec 3, 2019
Merged

PHP 7.4 support #16

merged 3 commits into from Dec 3, 2019

Conversation

phy25
Copy link

@phy25 phy25 commented Dec 1, 2019

This patch adds support for PHP7.4 by:

  • add 7.4snapshot to travis CI (they don't have the official PHP 7.4 release ready yet)
  • fix: Array and string offset access syntax with curly braces is deprecated
    src/LesserPhp/Compiler.php:1793
  • fix: Trying to access array offset on value of type bool
    src/LesserPhp/Compiler.php:953
  • fix: styleci warning

Array and string offset access syntax with curly braces is deprecated
/home/travis/build/phy25/lesserphp/src/LesserPhp/Compiler.php:1793

Trying to access array offset on value of type bool
/home/travis/build/phy25/lesserphp/src/LesserPhp/Compiler.php:953
@MarcusSchwarz MarcusSchwarz merged commit 280dc40 into MarcusSchwarz:master Dec 3, 2019
@MarcusSchwarz
Copy link
Owner

Thank you, @phy25 !

@glensc
Copy link

glensc commented Aug 10, 2020

@MarcusSchwarz can you please take care of #19 as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants