Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor field handling in PresetItem #736

Closed
simonpoole opened this issue Jun 16, 2018 · 2 comments
Closed

Refactor field handling in PresetItem #736

simonpoole opened this issue Jun 16, 2018 · 2 comments
Labels
Maintainability Usability Work in progress
Milestone
11.1

Comments

@simonpoole
Copy link
Collaborator

Move the fields to own objects and maintain them in a list so that order is preserved.
@simonpoole simonpoole changed the title Refactor file handling in PresetItem Refactor field handling in PresetItem Jun 19, 2018
@simonpoole simonpoole added this to the 11.1 milestone Jun 19, 2018
@simonpoole
Copy link
Collaborator Author

simonpoole commented Aug 17, 2018 •
edited

Basic refactoring done in 8f59088

TODO:

  • filter relation roles on element type
  • fix icon in combo regression
  • label support
  • check group support (time permitting)

@simonpoole
Copy link
Collaborator Author

Done in be350c5 note currently no direct label support as rather tricky to get right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Maintainability Usability Work in progress
Projects
None yet
Milestone
11.1
Development

No branches or pull requests
1 participant
@simonpoole