Return punish result as a bool and not str

MarechJ · May 21, 2024 · d1efa04 · d1efa04
1 parent 00104ca
commit d1efa04
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/rcon/commands.py b/rcon/commands.py
@@ -604,8 +604,11 @@ def remove_map_from_rotation(
         return self._str_request(cmd, can_fail=False, log_info=True)
 
     @_escape_params
-    def punish(self, player_name: str, reason: str) -> str:
-        return self._str_request(f'punish "{player_name}" "{reason}"', log_info=True)
+    def punish(self, player_name: str, reason: str) -> bool:
+        return (
+            self._str_request(f'punish "{player_name}" "{reason}"', log_info=True)
+            == SUCCESS
+        )
 
     @_escape_params
     def kick(self, player_name: str, reason: str) -> bool:

diff --git a/rcon/rcon.py b/rcon/rcon.py
@@ -1120,7 +1120,7 @@ def ban_profanities(self, profanities: list[str]) -> bool:
         with invalidates(self.get_profanities):
             return super().ban_profanities(",".join(profanities))
 
-    def punish(self, player_name: str, reason: str, by: str) -> str:
+    def punish(self, player_name: str, reason: str, by: str) -> bool:
         res = super().punish(player_name, reason)
         safe_save_player_action(
             rcon=self,