Standalone index #53
Merged
Standalone index #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes index complete in the sense that you can deploy an index instance and build a complete separate application on top of it, without having to go through the Marginalia-laden search service.
…extraction. Prefer working on DecoratedSearchResultItem in favor of UrlDetails.
This is an intermediate step in the process of introducing the query-service as a proxy between search and index.
This is a better descriptor, since they now all implement different applications on top of the core services' APIs.
Application services should not have an API, but purely act as clients to the core services (which should always have an API).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all features essential to search away from the marginalia-branded search service and into the index or a new query-service.
This will improve separation of concerns and make it possible to build other search engines applications off the project's back-end, and also enable future multiplexing against multiple backing indices without bothering the clients with the details of this.
Architectural changes:
A second design pass will probably be needed to clean up the query service's API and make it more easy to understand and use.