New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design Revamp For search.marginalia.nu #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlofgren
force-pushed
the
new-look
branch
4 times, most recently
from
November 29, 2023 14:31
2eee4d8
to
b53bdca
Compare
Also optimize the rendering a bit to avoid having to allocate huge string buffers, writing directly to Spark's response instead.
Avoid foot-gun caused by name clash with the Enumeration method name(), which returns the Java name of the enumeration value.
For future shenanigans ;D
…ktop UX in small ways.
Makes it easier to distinguish form the search button.
WIP: This commit needs to be cleaned up.
vlofgren
changed the title
(WIP) Design Revamp For search.marginalia.nu
Design Revamp For search.marginalia.nu
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overhauling the design for the search engine a bit, to make it more maintainable and to sand down a few of the rough edges in the current user interface.