Configurable domain ranking sets #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will free the core marginalia search engine to use arbitrary search set definitions, while the app can use its hardcoded defaults.
…ranking parameters
Still missing is some polish, forms don't have proper labels, validation is inconsistent, no error messages, etc.
The change also adds basic support for error messages in the GUI.
In some scenarios, such as when restoring storage items from json-manifest on db failure, the file storage view would present the items in a non-chronological order. Added a sort() operation to mitigate this.
id property was on the wrong element.
vlofgren
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make domain ranking sets configurable in the control GUI. The previous workflow required editing byzantine yaml files, and navigating hard-coded set names.
This change adds a data model for ranking set configurations, the index, which needs to use the new data model,
and the control GUI which needs a basic CRUD workflow for configuring the data.