Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONJ-541 resultSet.relative() behavior is incorrect when crossing result set boundaries #115

Merged
merged 3 commits into from
Oct 27, 2017

Conversation

yrodiere
Copy link
Contributor

This PR changes the behavior of resultSet.relative() when crossing result set boundaries in order to conform to the java.sql.ResultSet#relative javadoc.

One existing test, DriverTest#testResultSetPositions, had to be altered because it relied on an incorrect behavior (expected relative(-1) from the first row to not change the position).

@rusher
Copy link
Collaborator

rusher commented Oct 27, 2017

Hi @yrodiere ,

Good contribution.

Similar to other open source projects, the MariaDB Foundation needs to have shared ownership of all code that is included in the MariaDB distribution. The easiest way to achieve this is by submitting your code under the BSD-new license. (The other alternative is to sign the code contribution agreement which can be found here: https://mariadb.com/kb/en/mariadb/mca/)

Please indicate in a comment below that you are contributing your new code of the whole pull request, including one or several files that are either new files or modified ones, under the BSD-new license or that you have filled out the contribution agreement and sent it.

Thanks,
diego

@yrodiere
Copy link
Contributor Author

I am contributing my new code of the whole pull request, including one or several files that are either new files or modified ones, under the BSD-new license.

Thanks.

@rusher rusher merged commit 1ac4f1b into mariadb-corporation:develop Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants